Unused announcer line is now used #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Untriaged
|
I didn't intend for this to start off as draft 💀 |
|
I believe the upstream merge might be causing this test fail, as it was the last thing merged; it's also blocking my other small PR #2113 from merging. |
deltanedas
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Did you know there's a line in the announcer's sound files for the bureaucratic error? I didn't until I played elsewhere (an EE fork.) Initially I thought "Oh, they commissioned that dude that did the announcer voicelines again" but it's just hiding in our own repo, it turns out. This enables that line to be played.
Why / Balance
It's in the files waiting to be used, it just wasn't hooked up. This fixes that.
Technical details
This touches the upstream events.yml file for the purpose of starting this audio. It is an easy one line change.
Media
Not player facing except for the announcement itself.
Requirements
Breaking changes
May break the upstream merge if bureaucratic error ever gets changed. If it is, simply move the comp for startAudio. If not, you should be fine.
Changelog
No CL no fun. It will be a fun surprise for people to hear this now.